feat: add entrypoint for cmake modules dir #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/feat/entrypoint
branch
2 times, most recently
from
cbcd269
to
adeea8f
Compare
Skylion007
approved these changes
Oct 19, 2022
henryiii
force-pushed
the
henryiii/feat/entrypoint
branch
from
adeea8f
to
5177f73
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/feat/entrypoint
branch
from
5177f73
to
7893bab
Compare
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Oct 20, 2022
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
EthanSteinberg
pushed a commit
to EthanSteinberg/pybind11
that referenced
this pull request
Oct 20, 2022
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
added a commit
that referenced
this pull request
Oct 21, 2022
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Oct 21, 2022
* Revert "feat: add entrypoint for cmake modules dir (pybind#4258)" This reverts commit 1d4a65e. * docs: revert changelog mention too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This can be used by tools (like scikit-build-core) to access the cmake modules directory. Suggested use:
Suggested changelog entry:
* Experimental support for ``cmake.modules`` entrypoint.