Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scratch PR for testing pybind11 v2.10.0 with Python 3.11rc2 #4271

Closed
wants to merge 2 commits into from

Commits on Oct 21, 2022

  1. embed.h Python 3.11 config.use_environment=1 + PYTHONPATH test (p…

    …ybind#4119)
    
    * Add debug fprintf to test_interpreter.cpp
    
    * Update `sys.path` from `PYTHONPATH` in Python >= 3.11 branch of `initialize_interpreter()`
    
    * Use `config.isolated = 0; config.use_environment = 1;`
    
    As suggsted by @vstinner here: pybind#4119 (comment)
    
    * Add `TEST_CASE("PYTHONPATH is used to update sys.path")`
    
    * Fix clang-tidy error.
    
    * Use `_putenv_s()` under Windows.
    
    * Fix clang-tidy error: argument name ... in comment does not match parameter name
    
    * Remove slash from PYTHONPATH addition, to work around Windows slash-vs-backslash issue.
    
    * Use `py::str(...)` instead of `.attr("__str__")` as suggested by @Skylion007
    
    Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com>
    
    Co-authored-by: Aaron Gokaslan <skylion.aaron@gmail.com>
    2 people authored and Ralf W. Grosse-Kunstleve committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    2488530 View commit details
    Browse the repository at this point in the history
  2. Revert "embed.h Python 3.11 config.use_environment=1 + PYTHONPATH

    … test (pybind#4119)"
    
    This reverts commit 2488530.
    Ralf W. Grosse-Kunstleve committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    549223a View commit details
    Browse the repository at this point in the history