fix: add guard for GCC <10.3 on C++20 #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if it is desired to store the guard somewhere else and have it referenced or just having 4 instances of the guard is fine. |
|
Also please let me know if you want to test on gcc 10.1 or 10.2 if that is even possible. |
|
AFK for a few more hours, can't look at code until then, but: let's not do
anything complicated. Low hanging fruits will do. IMO
…On Thu, Jun 27, 2024 at 16:35 Michael Carlstrom ***@***.***> wrote:
Also please let me know if you want to test on gcc 10.1 or 10.2 if that is
even possible.
—
Reply to this email directly, view it on GitHub
<#5205 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFUZAG7CR5WWHGNEQL6Y4LZJSOTDAVCNFSM6AAAAABKAYBWU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVHAZTCNJZHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
henryiii
changed the title
henryiii
changed the title
henryiii
changed the title
Yeah, that was a bit much of duplicated code, but it's very easily avoided. I went ahead and did that. Thanks for creating this PR, from there it was very quick. |
rwgk
approved these changes
Jun 28, 2024
EchterAgo
added a commit
to EchterAgo/Electron-Cash
that referenced
this pull request
Jul 6, 2024
This is to make `zxing-cpp` build again. The root cause is an issue in `pybind11`, see: * https://github.com/pybind/pybind11/releases/tag/v2.13.1 * pybind/pybind11#5201 * pybind/pybind11#5205 * zxing-cpp/zxing-cpp#803
henryiii
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Update CI * update define guard * style: pre-commit fixes * updated define guard * style: pre-commit fixes * update guard * testing new guards * update guards * surely this time * style: pre-commit fixes * Define PYBIND11_TYPING_H_HAS_STRING_LITERAL to avoid repeating a complex expression. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rwgk@google.com>
henryiii
pushed a commit
that referenced
this pull request
Aug 13, 2024
* Update CI * update define guard * style: pre-commit fixes * updated define guard * style: pre-commit fixes * update guard * testing new guards * update guards * surely this time * style: pre-commit fixes * Define PYBIND11_TYPING_H_HAS_STRING_LITERAL to avoid repeating a complex expression. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ralf W. Grosse-Kunstleve <rwgk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5201 and updates CI.
Suggested changelog entry: