feat(types) C++ int and bool Literals in Python Literal Type #5463
Conversation
|
Failing test is unrelated see #5464. |
| typedef py::typing::Literal<26, | ||
| 0x14, | ||
| py::typing::StringLiteral("\"hello world\""), | ||
| py::typing::StringLiteral("b\"hello world\""), | ||
| py::typing::StringLiteral("u\"hello world\""), | ||
| true, | ||
| py::typing::StringLiteral("Color.RED"), | ||
| py::typing::StringLiteral("None")> |
There was a problem hiding this comment.
Just skimming over this, but would a simple string literal than have to use:
py::typing::Literal<py::typing::StringLiteral("hello")>?
Would be nice if strings could be used directly.
There was a problem hiding this comment.
What could be done I believe is only allow each Literal of the same type. Then I don't think you would need the py::typing::Literal<py::typing::StringLiteral("hello")> however, you wouldn't be able to mix non-type templates inside Literals and would need to use Unions.
There was a problem hiding this comment.
After messing around with various solutions the only one I could get working is make different named literals.
py::typing::LiteralString"Hi">
py::typing::LiteralInt<1, 2, 3>
py::typing::LiteralBool<true>To avoid confusion if we wanted to move forward with this the current typing::StringLiteral would be change to typing::fixed_string.
InvincibleRMC
force-pushed
the
C++-int-and-bool-Literal-Types
branch
from
efdf223 to
046277e
Compare
Description
typing.Literalnow can accept straight ints and bools, rather than only string Literals previously. For more information check out the python pep here.Suggested changelog entry:
Update `typing.Literal` type to support C++ ints and bools