Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BPX support #246

Merged
merged 13 commits into from
Apr 5, 2024
Merged

Add BPX support #246

merged 13 commits into from
Apr 5, 2024

Conversation

NicolaCourtier
Copy link
Member

@NicolaCourtier NicolaCourtier commented Mar 19, 2024

Description

Add support for importing BPX JSON files as parameter sets.

Issue reference

Adds feature request #79.

Type of change

  • New Feature: A non-breaking change that adds new functionality.

@NicolaCourtier NicolaCourtier linked an issue Mar 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.42%. Comparing base (9dbf1fa) to head (3a10ea7).
Report is 1 commits behind head on develop.

Files Patch % Lines
pybop/models/empirical/ecm.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #246      +/-   ##
===========================================
+ Coverage    95.35%   95.42%   +0.07%     
===========================================
  Files           36       36              
  Lines         1979     1990      +11     
===========================================
+ Hits          1887     1899      +12     
+ Misses          92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolaCourtier NicolaCourtier changed the title [WIP]: Add BPX support Add BPX support Mar 21, 2024
Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @NicolaCourtier, on a whole this looks great! I've made two small comments that are worth investigating before merging. Let me know what you think.

pybop/parameters/parameter_set.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @NicolaCourtier.

LGTM, just one suggestion on the unit tests.

tests/unit/test_models.py Outdated Show resolved Hide resolved
@NicolaCourtier NicolaCourtier merged commit 68203df into develop Apr 5, 2024
31 checks passed
@NicolaCourtier NicolaCourtier deleted the 79-bpx-support branch April 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BPX support
2 participants