-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds DFN, MPM, MSMR models #250
Conversation
…pdt base_model class naming to align across the codebase
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #250 +/- ##
===========================================
+ Coverage 95.44% 95.47% +0.02%
===========================================
Files 36 36
Lines 1998 2011 +13
===========================================
+ Hits 1907 1920 +13
Misses 91 91 ☔ View full report in Codecov by Sentry. |
… pouch-cell example, wrap model solve with exception catching for non-coverging conditions, limit default pybamm.solver.max_step_decrease_count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions! Thanks @BradyPlanden
Description
This PR completes the following:
Issue reference
Fixes #219
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s docs
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.