Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment PyBaMM > 23.5 #252

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Mar 22, 2024

Description

Increments PyBaMM > 23.5 to ensure pybamm.Thevenin is usable within PyBOP and fixes the current failing scheduled tests.

Issue reference

Fixes #251

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s docs

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@BradyPlanden BradyPlanden linked an issue Mar 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (4ac6b75) to head (e92928c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #252   +/-   ##
========================================
  Coverage    95.49%   95.49%           
========================================
  Files           38       38           
  Lines         2040     2040           
========================================
  Hits          1948     1948           
  Misses          92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden changed the base branch from develop to 236-scipy-kwargs March 28, 2024 08:16
@BradyPlanden BradyPlanden changed the base branch from 236-scipy-kwargs to develop March 28, 2024 08:17
…integration tests in parameterisation tests
@BradyPlanden BradyPlanden force-pushed the 251-bug-scheduled-test-failing-on-pybamm-235 branch from c445aff to c7ef869 Compare April 8, 2024 16:48
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BradyPlanden! Just a few comments.

scripts/ci/build_matrix.sh Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
@BradyPlanden BradyPlanden merged commit 91f0373 into develop Apr 18, 2024
28 checks passed
@BradyPlanden BradyPlanden deleted the 251-bug-scheduled-test-failing-on-pybamm-235 branch April 18, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Scheduled test failing on PyBaMM 23.5
2 participants