-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames model.rebuild
variables, updates import structure, adds type-hints to BaseModel
#315
Conversation
…rameters to geometric_parameters in child classes
This reverts commit 87cd2bb.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #315 +/- ##
===========================================
- Coverage 97.20% 97.07% -0.13%
===========================================
Files 45 41 -4
Lines 2612 2328 -284
===========================================
- Hits 2539 2260 -279
+ Misses 73 68 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BradyPlanden, great to see all the type hints! I think we can now update parameters from Dict to Parameters type.
Description
model.matched_parameters
->model.rebuild_parameters
andmodel.non_matched_parameters
->model.standard_parameters
for better user comprehension. The previousmodel.rebuild_parameters
is likewise renamed tomodel.geometric_parameters
BaseModel
where possible_handle_special_cases()
method into ECM to remove circular referencesetitem
andgetitem
to pybop.ParameterSetIssue reference
Fixes # (issue-number)
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.