Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a WeightedCost #329

Merged
merged 40 commits into from
Jul 22, 2024
Merged

Add a WeightedCost #329

merged 40 commits into from
Jul 22, 2024

Conversation

NicolaCourtier
Copy link
Member

Description

Add a WeightedCost class to combine costs and avoid duplicate problem evaluations where possible.

Issue reference

Fixes #327

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@NicolaCourtier NicolaCourtier mentioned this pull request May 16, 2024
13 tasks
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 99.02913% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.10%. Comparing base (4f7eb59) to head (766bd16).
Report is 1 commits behind head on develop.

Files Patch % Lines
pybop/costs/_weighted_cost.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #329   +/-   ##
========================================
  Coverage    98.10%   98.10%           
========================================
  Files           43       44    +1     
  Lines         2632     2697   +65     
========================================
+ Hits          2582     2646   +64     
- Misses          50       51    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolaCourtier NicolaCourtier marked this pull request as ready for review July 5, 2024 11:11
Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NicolaCourtier - this is looking great, I've made some suggestions in 327b to enable the design based costs. I'm happy for this to be merged ahead of that, or to have them merged together and then into develop. Looking forward to this functionality :)

pybop/costs/_weighted_cost.py Show resolved Hide resolved
@NicolaCourtier NicolaCourtier merged commit f3a32bc into develop Jul 22, 2024
30 checks passed
@NicolaCourtier NicolaCourtier deleted the 327-weighted-cost branch July 22, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a WeightedCost class
2 participants