-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align optimisation result #334
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #334 +/- ##
===========================================
+ Coverage 97.07% 97.24% +0.16%
===========================================
Files 41 41
Lines 2328 2322 -6
===========================================
- Hits 2260 2258 -2
+ Misses 68 64 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NicolaCourtier, this is a nice addition! It's a great step towards a larger Results
class to be used across the library. A few comments to look at :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can combine the imports, otherwise LGTM! Thanks @NicolaCourtier :)
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
Description
Move the Result class into base_optimiser.py and use it to align the results returned by all optimisers.
Issue reference
Fixes #271
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.