Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds plotting methods for monte carlo samplers #409

Merged
merged 20 commits into from
Oct 29, 2024

Conversation

BradyPlanden
Copy link
Member

Description

This PR adds plotting methods for the sampling methods constructed in #340.

Issue reference

Fixes #6

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (c8b00e6) to head (0a51d95).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #409      +/-   ##
===========================================
+ Coverage    99.08%   99.11%   +0.03%     
===========================================
  Files           52       55       +3     
  Lines         3605     3857     +252     
===========================================
+ Hits          3572     3823     +251     
- Misses          33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from monte-carlo-methods to develop September 2, 2024 08:31
@BradyPlanden BradyPlanden added the ask This PR needs a review for merging label Oct 11, 2024
@BradyPlanden BradyPlanden marked this pull request as ready for review October 16, 2024 15:08
Copy link
Member

@NicolaCourtier NicolaCourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @BradyPlanden

@BradyPlanden BradyPlanden merged commit a756d27 into develop Oct 29, 2024
31 checks passed
@BradyPlanden BradyPlanden deleted the monte-carlo-plotting branch October 29, 2024 15:27
BradyPlanden added a commit that referenced this pull request Nov 25, 2024
* feat: initial monte carlo plotting, summary functionality

temp commit

* plots: update mcmc_summary, remove stale unit tests, align mcmc_example with plotting methods.

* adds autocorrelation and ess methods for posterior chains

* style: pre-commit fixes

* Adds ECM monte carlo identification example, updates and bugfixes to posterior_summary

* tests: coverage for PosteriorSummary()

* Move data/Tesla_4680 files

* fix: lychee, multiprocessing, plotly.go management

* Adds coverage for effective sample size, autocorrelation

* tests: coverage and removes redundant checks

* Update notebook sampler, starting position from optimisation, parallelisation

* adds rhat() to PosteriorSummary, updates monte_carlo_ecm example for MAP estimate & initialisation

* examples: post-merge fix

* tests: adds rhat assertion, updates thevenin sampling for MAP estimate x0.

* moves x0 checks, construction to BaseSampler, updates tests, fixes transformations in samplers

* adds coverage, updates multi_fitting.py.

* fix: x0 in BaseSampler shape, updates sampler & observer tests

* style: pre-commit fixes

* fix: plot architecture change

* adds changelog entry, updates to mcmc_example.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask This PR needs a review for merging
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hamiltonian Monte Carlo (HMC)
2 participants