-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds plotting methods for monte carlo samplers #409
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #409 +/- ##
===========================================
+ Coverage 99.08% 99.11% +0.03%
===========================================
Files 52 55 +3
Lines 3605 3857 +252
===========================================
+ Hits 3572 3823 +251
- Misses 33 34 +1 ☔ View full report in Codecov by Sentry. |
ac7ef76
to
7a50b7a
Compare
…le with plotting methods.
…posterior_summary
…MAP estimate & initialisation
…ansformations in samplers
19fe3bf
to
10a74f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @BradyPlanden
* feat: initial monte carlo plotting, summary functionality temp commit * plots: update mcmc_summary, remove stale unit tests, align mcmc_example with plotting methods. * adds autocorrelation and ess methods for posterior chains * style: pre-commit fixes * Adds ECM monte carlo identification example, updates and bugfixes to posterior_summary * tests: coverage for PosteriorSummary() * Move data/Tesla_4680 files * fix: lychee, multiprocessing, plotly.go management * Adds coverage for effective sample size, autocorrelation * tests: coverage and removes redundant checks * Update notebook sampler, starting position from optimisation, parallelisation * adds rhat() to PosteriorSummary, updates monte_carlo_ecm example for MAP estimate & initialisation * examples: post-merge fix * tests: adds rhat assertion, updates thevenin sampling for MAP estimate x0. * moves x0 checks, construction to BaseSampler, updates tests, fixes transformations in samplers * adds coverage, updates multi_fitting.py. * fix: x0 in BaseSampler shape, updates sampler & observer tests * style: pre-commit fixes * fix: plot architecture change * adds changelog entry, updates to mcmc_example.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
This PR adds plotting methods for the sampling methods constructed in #340.
Issue reference
Fixes #6
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.