Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptography 3.4 should not have an install_requires on setuptools_rust #5778

Closed
tiran opened this issue Feb 8, 2021 · 1 comment · Fixed by #5779
Closed

cryptography 3.4 should not have an install_requires on setuptools_rust #5778

tiran opened this issue Feb 8, 2021 · 1 comment · Fixed by #5779

Comments

@tiran
Copy link
Contributor

tiran commented Feb 8, 2021

setup.py lists setuptools_rust as setup and as installation dependency. cryptography only needs setuptools_rust during setup. The additional dependency causes issues with Fedora's automatic dependency generator, see https://bugzilla.redhat.com/show_bug.cgi?id=1926181

setup_requirements = ["cffi>=1.12", "setuptools-rust>=0.11.4"]


setup(
    ...
    install_requires=setup_requirements,
    setup_requires=setup_requirements,
)
tiran added a commit to tiran/cryptography that referenced this issue Feb 8, 2021
@tiran
Remove setuptools_rust from install requirement
d9cfdd5 
setuptools_rust is only required for building cryptography.

Fixes: pyca#5778
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran mentioned this issue Feb 8, 2021
Merged
@tom--pollard
Copy link

tom--pollard commented Feb 8, 2021 •
edited
Loading

Also hitting this issue when trying to pip install docker-compose in an alpine container

@alex alex closed this as completed in #5779 Feb 8, 2021
alex pushed a commit that referenced this issue Feb 8, 2021
@tiran
Remove setuptools_rust from install requirement (#5779)
048f7c6 
* Remove setuptools_rust from install requirement

setuptools_rust is only required for building cryptography.

Fixes: #5778
Signed-off-by: Christian Heimes <cheimes@redhat.com>

* sdist needs setuptools_rust

Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran added a commit to tiran/cryptography that referenced this issue Feb 8, 2021
@tiran
Remove setuptools_rust from install requirement (pyca#5779)
c2594c1 
* Remove setuptools_rust from install requirement

setuptools_rust is only required for building cryptography.

Fixes: pyca#5778
Signed-off-by: Christian Heimes <cheimes@redhat.com>

* sdist needs setuptools_rust

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran mentioned this issue Feb 8, 2021
Merged
reaperhulk pushed a commit that referenced this issue Feb 8, 2021
@tiran
Remove setuptools_rust from install requirement (#5779) (#5781)
843ada6 
* Remove setuptools_rust from install requirement

setuptools_rust is only required for building cryptography.

Fixes: #5778
Signed-off-by: Christian Heimes <cheimes@redhat.com>

* sdist needs setuptools_rust

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove setuptools_rust from install requirement tiran/cryptography
2 participants
@tiran @tom--pollard