initialize openssl's legacy provider in rust #10323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperhulk
force-pushed
the
legacy-provider-load
branch
5 times, most recently
from
36ece4f
to
e689af1
Compare
alex
reviewed
Feb 2, 2024
alex
reviewed
Feb 2, 2024
reaperhulk
force-pushed
the
legacy-provider-load
branch
from
c8200db
to
4f9a3d7
Compare
as we oxidize we need to do this here to ensure it actually happens
reaperhulk
force-pushed
the
legacy-provider-load
branch
from
4f9a3d7
to
b626fec
Compare
alex
reviewed
Feb 2, 2024
src/rust/src/lib.rs
Outdated
Comment on lines
41
to
45
| /* As of OpenSSL 3.0.0 we must register a legacy cipher provider | ||
| to get RC2 (needed for junk asymmetric private key | ||
| serialization), RC4, Blowfish, IDEA, SEED, etc. These things | ||
| are ugly legacy, but we aren't going to get rid of them | ||
| any time soon. */ |
There was a problem hiding this comment.
Use // comments, not this weirdo crap
alex
approved these changes
Feb 2, 2024
reaperhulk
added a commit
to reaperhulk/cryptography
that referenced
this pull request
Feb 2, 2024
* initialize openssl's legacy provider in rust as we oxidize we need to do this here to ensure it actually happens * alex is a comment format pedant
alex
pushed a commit
that referenced
this pull request
Feb 3, 2024
* initialize openssl's legacy provider in rust (#10323) * initialize openssl's legacy provider in rust as we oxidize we need to do this here to ensure it actually happens * alex is a comment format pedant * remove the memleak tests (#10322) they are fragile, haven't caught regressions, and increasingly pointless as we oxidize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we oxidize we need to do this here to ensure it actually happens