tolerate NULL params in ECDSA SHA2 AlgorithmIdentifier #9002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 11 does this incorrectly. It was fixed in Java16+ and they are planning to do a backport, but we'll need to tolerate this invalid encoding for a while.
alex
reviewed
Jun 1, 2023
alex
reviewed
Jun 1, 2023
reaperhulk
force-pushed
the
tolerate-bad-certs
branch
from
9e474da to
502f04d
Compare
alex
approved these changes
Jun 1, 2023
reaperhulk
added a commit
to reaperhulk/cryptography
that referenced
this pull request
Jun 1, 2023
* tolerate NULL params in ECDSA SHA2 AlgorithmIdentifier Java 11 does this incorrectly. It was fixed in Java16+ and they are planning to do a backport, but we'll need to tolerate this invalid encoding for a while. * test both inner and outer
alex
pushed a commit
that referenced
this pull request
Jun 1, 2023
* tolerate NULL params in ECDSA SHA2 AlgorithmIdentifier (#9002) * tolerate NULL params in ECDSA SHA2 AlgorithmIdentifier Java 11 does this incorrectly. It was fixed in Java16+ and they are planning to do a backport, but we'll need to tolerate this invalid encoding for a while. * test both inner and outer * changelog entry * language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 11 does this incorrectly. It was fixed in Java16+ and they are planning to do a backport, but we'll need to tolerate this invalid encoding for a while.