Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ALPN / NPN #79

Closed
radix opened this issue Mar 26, 2014 · 11 comments
Closed

Support ALPN / NPN #79

radix opened this issue Mar 26, 2014 · 11 comments

Comments

@radix
Copy link

radix commented Mar 26, 2014

pyOpenSSL should support ALPN/NPN since OpenSSL now supports it:

http://git.openssl.org/gitweb/?p=openssl.git;a=commit;h=6f017a8f9db3a79f3a3406cf8d493ccd346db691

@Lukasa
Copy link
Member

Lukasa commented Mar 27, 2014

As far as I can tell PyOpenSSL also doesn't support NPN: it'd be nice to get that as well. I'll look into whether I've got the skillset to implement it.

@exarkun
Copy link
Member

exarkun commented Mar 27, 2014

@Lukasa
Copy link
Member

Lukasa commented Mar 27, 2014

@exarkun Interesting, I'll see if I can cleanly merge those commits.

@Lukasa
Copy link
Member

Lukasa commented Mar 27, 2014

Wait, I clearly can't, they're from before we were using cffi. =)

@alex
Copy link
Member

alex commented Mar 27, 2014

Yeah, they'll need to be rewritten -- that should be straightforward though
(will probably require a few contributions for cryptography).

On Thu, Mar 27, 2014 at 1:16 PM, Cory Benfield notifications@git.luolix.topwrote:

Wait, I clearly can't, they're from before we were using cffi. =)


Reply to this email directly or view it on GitHubhttps://github.com//issues/79#issuecomment-38855061
.

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

@Lukasa
Copy link
Member

Lukasa commented Mar 27, 2014

OK, I don't necessarily have a great handle on what I'm doing (cffi and OpenSSL both being unfamiliar to me), but the easiest thing to start with is to update cryptography to add the necessary functions, so I'll do that.

@Lukasa
Copy link
Member

Lukasa commented Mar 31, 2014

Ok, NPN support is in #86. I'll aim to do ALPN once we get that merged.

@Lukasa
Copy link
Member

Lukasa commented Jun 5, 2014

For those tracking this issue, #86 wasn't rejected, we just moved it to #110.

This was referenced Jun 7, 2014
@Lukasa
Copy link
Member

Lukasa commented Jun 7, 2014

Ok, ALPN pull request is open in #120.

@ihamburglar
Copy link
Contributor

Perhaps we should close this issue?

@alex alex closed this as completed Apr 28, 2015
@alex
Copy link
Member

alex commented Apr 28, 2015

thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants