Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compatible with new pycasbin #15

Merged
merged 1 commit into from
Aug 2, 2022
Merged

fix: compatible with new pycasbin #15

merged 1 commit into from
Aug 2, 2022

Conversation

Nekotoxin
Copy link
Contributor

@Nekotoxin Nekotoxin commented Aug 2, 2022 •
edited by hsluoyz
Loading

Fix: #14

@eremeevfd
Copy link

eremeevfd commented Aug 2, 2022 •
edited
Loading

@Nekotoxin Can you also check please this error:

  File "/Users/f.eremeev/saas/saas_core_v2/source/.venv/lib/python3.10/site-packages/casbin/core_enforcer.py", line 65, in __init__
    self.init_with_model_and_adapter(model, adapter)
  File "/Users/f.eremeev/saas/saas_core_v2/source/.venv/lib/python3.10/site-packages/casbin/core_enforcer.py", line 85, in init_with_model_and_adapter
    raise RuntimeError("Invalid parameters for enforcer.")
RuntimeError: Invalid parameters for enforcer.

It appears when enable_logging is dropped

Or is it just my misconfig and model shouldn't be a path?

@eremeevfd
Copy link

@Nekotoxin Okay, this was an issue with my model path type, I had PosixPath, manually converted it to string and everything worked

@eremeevfd
Copy link

Thank you for the fix @Nekotoxin ! I'm really looking forward to this merge :)

@hsluoyz hsluoyz merged commit 9cea17d into pycasbin:master Aug 2, 2022
github-actions bot pushed a commit that referenced this pull request Aug 2, 2022
@semantic-release-bot
chore(release): 1.0.1 [skip ci]
515ef1e 
## [1.0.1](v1.0.0...v1.0.1) (2022-08-02)

### Bug Fixes

* compatible with new pycasbin ([#15](#15)) ([9cea17d](9cea17d))
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Casbin lib incompatibility
3 participants
@Nekotoxin @eremeevfd @hsluoyz