Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are installed #47

Closed
dvzrv opened this issue Nov 12, 2022 · 2 comments · Fixed by #56
Closed

Tests are installed #47

dvzrv opened this issue Nov 12, 2022 · 2 comments · Fixed by #56
Labels
bug Something isn't working

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Nov 12, 2022

Hi! I'm packaging this project on Arch Linux.
I noticed that the test files are installed alongside the files of this project, but they are not required during runtime and should therefore end up on a user system.

@dvzrv
Copy link
Contributor Author

dvzrv commented Nov 12, 2022

This warning is also thrown during build of the wheel:

/usr/lib/python3.10/site-packages/setuptools/command/build_py.py:202: SetuptoolsDeprecationWarning:     Installing 'enrich.test' as data is deprecated, please list it in `packages`.
    !!


    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'enrich.test' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'enrich.test' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'enrich.test' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.


!!

@ssbarnea
Copy link
Member

ssbarnea commented Dec 1, 2022

Feel free to move them out of the package, to ./test.

@ssbarnea ssbarnea added the bug Something isn't working label Dec 1, 2022
ssbarnea added a commit that referenced this issue Dec 20, 2022
ssbarnea added a commit that referenced this issue Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants