Do not make use of pytest.warns(None) #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is no longer needed due to similar test fixes which have been merged |
|
I'm happy to rebase this PR to just make that change. |
|
Good callout, please do so |
One test case after the transition from pytest.warns(None) is attempting to check it raises no warnings, but as written the context manager swallows all warnings. Set the filter to error to make certain they are raised.
s-t-e-v-e-n-k
force-pushed
the
no-more-pytest-warns-None
branch
from
3c11258 to
a416c80
Compare
|
I've rebased, made that one line change and rewritten the commit message (but not the PR description/title) |
clintonsteiner
approved these changes
Jan 9, 2025
|
thank you @s-t-e-v-e-n-k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest.warns(None) is an anti-pattern, and there are easier ways to accomplish both cases with how the code is leveraging pytest.warns(). Firstly, it can match on a specific warning and will assert that the warning is raised -- and it doesn't need to be used if we want to assert code raises no warnings, the standard library can do that directly. Furthermore, pytest.warns(None) is an error in Pytest 8 and above.