Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add illustrative image to README #39

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

rjvitorino
Copy link
Contributor

Added an illustrative image to the README file to provide a visual example of using the 'refry' retry decorator. This image enhances the documentation by showing upfront a code snippet demonstrating the decorator's action. Updated the README to include this visual aid for better user understanding.

Added an illustrative image to the README file to provide a visual example of using the 'refry' retry decorator. This image enhances the documentation by showing upfront a code snippet demonstrating the decorator's action. Updated the README to include this visual aid for better user understanding.
@rjvitorino
Copy link
Contributor Author

Here's the image, to avoid having a link to my fork (didn't manage how to make it "transferrable"):

refry

Switches the URL of the PNG to pydanny's repo (after uploading it in a pull request comment)
@rjvitorino
Copy link
Contributor Author

Here's the image, to avoid having a link to my fork (didn't manage how to make it "transferrable"):

refry

Updated the README with the link from this comment, but am not sure if/when Github will throw it away after closing or deleting the pull request...

Copy link
Owner

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I've seen this more and more. While I prefer code examples, I know others have their own way to look at things. Let's do it!

@rjvitorino
Copy link
Contributor Author

Great! I then recommend you to merge the approved Pull requests in order. #38 then #39 or #40

Copy link
Owner

@pydanny pydanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pydanny pydanny merged commit dbea48d into pydanny:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants