-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility issue with python <3.11 #45
Conversation
a suggestion -> ui test would be definitely needed if you intend to write useful tests I'd be happy to give a hand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot, thanks. I think a simpler solution would be preferable as described above.
On playwright, maybe at some point we need e2e tests, but I'd rather postpone them as long as possible possible as they generally only act as a smoke test and slow down development significantly. Let's start with #18, python tests, and even some unit tests for the more complex bits of typescript code, and see how we get on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still isn't compatible, line 67 needs
def fill_fields(self) -> typing.Self:
-> def fill_fields(self) -> typing_extensions.Self
I don't have permission to directly comment a line, so commenting here instead.
Also missing a typing_extensions import for |
Good points, thanks. I'll add some basic tests to ci and fix all this stuff some time soon |
great, thanks so much. |
There's no tests yet?
didn't know where to place them
fixes #42.