feat/demo-running-instructions #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-danis
reviewed
Dec 3, 2023
samuelcolvin
reviewed
Dec 3, 2023
python/requirements/lint.txt
Outdated
| @@ -13,3 +13,4 @@ ruff==0.1.5 | |||
|
|
|||
| # The following packages are considered to be unsafe in a requirements file: | |||
| # setuptools | |||
| pre-commit | |||
There was a problem hiding this comment.
no need, this is already in make install, also this file should only be updated by make update-lockfiles from the *.in files.
|
I will work on some testing and cleanup of this PR in the next day. Thanks for the feedback, I was just bushwacking my way through the repo, trying to figure it all out. I'm excited to play with and explore the project, hopefully make it easier for others to dig in. |
|
Makes sense, thanks so much for submitting this, it's definitely very necessary. |
|
I did a bit of cleanup, and will merge. Thanks so much for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated running instructions for the demo app