Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make fuzz checks more lenient #133

Merged
merged 3 commits into from
Sep 9, 2024
Merged

make fuzz checks more lenient #133

merged 3 commits into from
Sep 9, 2024

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Sep 9, 2024

Fix fuzz failures on #130 and #132.

@samuelcolvin samuelcolvin enabled auto-merge (squash) September 9, 2024 12:35
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (eccf28e) to head (796152a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   94.92%   94.91%   -0.01%     
==========================================
  Files          12       12              
  Lines        1910     1908       -2     
==========================================
- Hits         1813     1811       -2     
  Misses         97       97              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eccf28e...796152a. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 9, 2024

CodSpeed Performance Report

Merging #133 will improve performances by 13.72%

Comparing fix-fuzz-failutres (796152a) with main (eccf28e)

Summary

⚡ 4 improvements
✅ 69 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-fuzz-failutres Change
sentence_serde_value 8.9 µs 7.9 µs +13.61%
true_array_jiter_skip 5.1 µs 4.5 µs +13.72%
python_parse_string_array_not_cached 40.2 µs 36.2 µs +11.15%
python_parse_true_array 16.6 µs 14.6 µs +13.42%

@samuelcolvin samuelcolvin merged commit dd25fd0 into main Sep 9, 2024
23 checks passed
@samuelcolvin samuelcolvin deleted the fix-fuzz-failutres branch September 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant