Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip test PyO3 HEAD #137

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip test PyO3 HEAD #137

wants to merge 1 commit into from

Conversation

davidhewitt
Copy link
Collaborator

PyO3 0.23 contains some breaking changes & perf changes, want to check these briefly against jiter & core...

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (4af2c1c) to head (62556ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          12       12           
  Lines        2042     2042           
  Branches     2042     2042           
=======================================
  Hits         1857     1857           
  Misses        112      112           
  Partials       73       73           
Files with missing lines Coverage Δ
crates/jiter/src/py_lossless_float.rs 92.72% <100.00%> (ø)
crates/jiter/src/py_string_cache.rs 97.05% <100.00%> (ø)
crates/jiter/src/python.rs 97.43% <100.00%> (ø)
crates/jiter/src/value.rs 81.71% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af2c1c...62556ff. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #137 will not alter performance

Comparing dh/pyo3-0.23 (62556ff) with main (4af2c1c)

Summary

✅ 73 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant