Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-bigint build failures, check those in CI #138

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

fasterthanlime
Copy link
Contributor

I forgot to fix a couple lines in the last PR — now they're checked by pre-commit, before committing (I'm assuming?) and in CI.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (b09b969) to head (ac903d0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files          12       12           
  Lines        2040     2040           
=======================================
  Hits         1929     1929           
  Misses        111      111           
Files with missing lines Coverage Δ
crates/jiter/src/value.rs 94.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09b969...ac903d0. Read the comment docs.

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #138 will degrade performances by 10.99%

Comparing bearcove:bigint-check (ac903d0) with main (b09b969)

Summary

❌ 1 regressions
✅ 72 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bearcove:bigint-check Change
sentence_jiter_value 7.9 µs 8.9 µs -10.99%

@fasterthanlime
Copy link
Contributor Author

CI failure is unrelated and perf regression is.. unexplainable. Oh well.

Copy link
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the perf regression seems to be just variance caused by allocations.

@davidhewitt davidhewitt merged commit ae5fc7d into pydantic:main Sep 18, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants