Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Cow in JsonValue #63

Merged
merged 8 commits into from
Mar 20, 2024
Merged

use Cow in JsonValue #63

merged 8 commits into from
Mar 20, 2024

Conversation

samuelcolvin
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Merging #63 (9364d47) into main (625b202) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   95.49%   95.74%   +0.25%     
==========================================
  Files           8        8              
  Lines        1110     1199      +89     
==========================================
+ Hits         1060     1148      +88     
- Misses         50       51       +1     
Files Coverage Δ
src/jiter.rs 99.50% <100.00%> (+0.03%) ⬆️
src/lazy_index_map.rs 97.97% <100.00%> (+0.25%) ⬆️
src/string_decoder.rs 94.15% <100.00%> (-0.48%) ⬇️
src/value.rs 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625b202...9364d47. Read the comment docs.

Copy link

codspeed-hq bot commented Jan 21, 2024

CodSpeed Performance Report

Merging #63 will improve performances by ×2.4

Comparing string-cow (9364d47) with main (625b202)

Summary

⚡ 5 improvements
✅ 49 untouched benchmarks

🆕 2 new benchmarks

Benchmarks breakdown

Benchmark main string-cow Change
medium_response_jiter_value 209.5 µs 152.4 µs +37.44%
🆕 medium_response_jiter_value_owned N/A 208.6 µs N/A
pass1_jiter_value 161.1 µs 126.9 µs +26.96%
string_array_jiter_value 167.3 µs 70.7 µs ×2.4
🆕 string_array_jiter_value_owned N/A 165.9 µs N/A
true_object_jiter_value 209.2 µs 112.9 µs +85.38%
x100_jiter_value 4.9 µs 3.4 µs +45.26%

Copy link
Collaborator

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 🚀

@davidhewitt davidhewitt marked this pull request as ready for review March 20, 2024 18:58
@davidhewitt davidhewitt merged commit 3b33e05 into main Mar 20, 2024
10 checks passed
@davidhewitt davidhewitt deleted the string-cow branch March 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants