Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some redundant python reference count ops #68

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

davidhewitt
Copy link
Collaborator

Avoiding the .to_object() calls just avoids reference count going up & back down needlessly.

Copy link

codspeed-hq bot commented Mar 13, 2024

CodSpeed Performance Report

Merging #68 will not alter performance

Comparing dh/python-cleanups (a6b952e) with main (0897da4)

Summary

✅ 54 untouched benchmarks

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #68 (a6b952e) into main (0897da4) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files           8        8           
  Lines        1110     1110           
=======================================
  Hits         1060     1060           
  Misses         50       50           
Files Coverage Δ
src/python.rs 95.12% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0897da4...a6b952e. Read the comment docs.

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :).

@davidhewitt davidhewitt merged commit 625b202 into main Mar 13, 2024
10 checks passed
@davidhewitt davidhewitt deleted the dh/python-cleanups branch March 13, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants