Fix memory leak caused by not visiting the function in a CallValidator during gc #1100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pydantic/pydantic#8239, I wouldn't be surprised if there was some connection to other memory issues we've noticed with
ValidateCall
(e.g., pydantic/pydantic#7687, though that one seemed to be addressed by doing a full garbage collection), either way this definitely seems like a bug.@davidhewitt not sure if it makes sense to add tests of any sort for this, otherwise I think we can just merge.