Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use input type json when validating a json schema #1117

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

dmontagu
Copy link
Collaborator

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #1117 (77f776c) into main (7fa450d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   89.70%   89.72%   +0.02%     
==========================================
  Files         106      106              
  Lines       16364    16367       +3     
  Branches       35       35              
==========================================
+ Hits        14680    14686       +6     
+ Misses       1677     1674       -3     
  Partials        7        7              
Files Coverage Δ
src/validators/json.rs 98.46% <100.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa450d...77f776c. Read the comment docs.

Copy link

codspeed-hq bot commented Dec 11, 2023

CodSpeed Performance Report

Merging #1117 will degrade performances by 14.06%

Comparing fix-json-validator (77f776c) with main (7fa450d)

Summary

❌ 1 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-json-validator Change
test_small_class_core_model 50.2 µs 58.4 µs -14.06%

@sydney-runkle sydney-runkle marked this pull request as ready for review December 11, 2023 17:24
Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@davidhewitt davidhewitt merged commit a5b3906 into main Dec 12, 2023
29 of 30 checks passed
@davidhewitt davidhewitt deleted the fix-json-validator branch December 12, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating Json[MyEnum] field with strict=True throws NotImplementedError
3 participants