Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updates for Rust 1.76 #1191

Merged
merged 1 commit into from
Feb 15, 2024
Merged

ci: updates for Rust 1.76 #1191

merged 1 commit into from
Feb 15, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Fixes new lint warnings from Rust 1.76.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Feb 12, 2024

CodSpeed Performance Report

Merging #1191 will improve performances by 25.17%

Comparing dh/rust-1.76 (7a9e158) with main (44621f1)

Summary

⚡ 4 improvements
✅ 142 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/rust-1.76 Change
test_core_future_str 39.2 µs 32.3 µs +21.26%
test_core_str 38.7 µs 31.9 µs +21.47%
test_core_future 37.5 µs 30 µs +25.17%
test_core_str 63.6 µs 56.5 µs +12.6%

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

@sydney-runkle sydney-runkle merged commit fadeecc into main Feb 15, 2024
27 checks passed
@sydney-runkle sydney-runkle deleted the dh/rust-1.76 branch February 15, 2024 13:33
sydney-runkle pushed a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants