Fix serialize_as_any with recursive ref

[nix010]

BaseModel.model_dump[_xxx](serialize_as_any = True) breaks with models with recursive attribute types (not values)
pydantic/pydantic#9670

Related issue number

fix pydantic/pydantic#9670

Checklist

• Unit tests for the changes exist
• Documentation reflects the changes where applicable
• Pydantic tests pass with this pydantic-core (except for expected changes)
• My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

[codspeed-hq]

CodSpeed Performance Report

Merging #1359 will not alter performance

_{Comparing nix010:fix-serialize-as-any-with-recursive-ref (d6fbaab) with main (e3eff5c)}

Summary

✅ 155 untouched benchmarks

[nix010]

@sydney-runkle I tested the python code and all good but how do I make an equivalent schema for the test here ?

from __future__ import annotations

import traceback

import pydantic


class Model1(pydantic.BaseModel):
    recursive: Model1 | None


class Model2(pydantic.BaseModel):
    recursive: pydantic.SerializeAsAny[Model2] | None

print(Model1(recursive=None).model_dump())
print(Model1(recursive=None).model_dump_json())
print(Model2(recursive=None).model_dump())
print(Model2(recursive=None).model_dump_json())

# All fail:
try:
    print(Model1(recursive=None).model_dump(serialize_as_any=True))
except:
    traceback.print_exc()

try:
    print(Model1(recursive=None).model_dump_json(serialize_as_any=True))
except:
    traceback.print_exc()

try:
    print(Model2(recursive=None).model_dump(serialize_as_any=True))
except:
    traceback.print_exc()

try:
    print(Model2(recursive=None).model_dump_json(serialize_as_any=True))
except:
    traceback.print_exc()

[sydney-runkle]

Good question - I normally just do

from pydantic._internal._core_utils import pretty_print_core_schema
from pydantic import BaseModel

class SomeModel(BaseModel): ...

pretty_print_core_schema(SomeModel.__pydantic_core_schema__)

And then go from that representation in order to build up an equivalent core schema

[nix010]

so what I found is that the outer serializer call to rescursive serializer but also put the self.definition.id() in the stack already. So when the rescursive serializer start to eval, the root model of it have the same self.definition.id() result in raise duplicated id error.

Checking for DuckTypingSerMode::Inferred is because that what I saw as a flag when the rescursive serializer started. I could be wrong so very open for suggestions !

[sydney-runkle]

Hmm, seems like a clever find. I think I'd like to have @davidhewitt take a look at this as well before we merge, he should be back soon :).

[davidhewitt]

This change (to not introduce recursion guards) is the cause of the segfaults in the tests in CI. (The tests now have unbounded recursion and blow the stack.)

[nix010]

have fixed the issue!

[sydney-runkle]

@NeevCohen, I'm finally back, and can review this either this evening or tomorrow morning!

[NeevCohen]

@sydney-runkle Welcome back! I think you meant to tag @nix010 😅

[sydney-runkle]

@NeevCohen ah yes, oops! Thanks! Meant to tag @nix010 :)

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (ab503cb) to head (d6fbaab).
Report is 190 commits behind head on main.

Files with missing lines	Patch %	Lines
src/serializers/type_serializers/definitions.rs	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
- Coverage   90.21%   89.21%   -1.00%     
==========================================
  Files         106      112       +6     
  Lines       16339    17818    +1479     
  Branches       36       41       +5     
==========================================
+ Hits        14740    15897    +1157     
- Misses       1592     1901     +309     
- Partials        7       20      +13     

Files with missing lines	Coverage Δ
src/serializers/extra.rs	96.45% <100.00%> (-3.08%)	⬇️
src/serializers/type_serializers/definitions.rs	84.52% <90.00%> (-15.48%)	⬇️

... and 49 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3eff5c...d6fbaab. Read the comment docs.

[sydney-runkle]

Closing in favor of #1478