Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize config and schema settings for extra_behavior #1424

Closed
wants to merge 1 commit into from

Conversation

sydney-runkle
Copy link
Member

Technically a breaking changes, but simplifies the API imo.

Still waiting on a reply for #1243 before we merge.

@sydney-runkle
Copy link
Member Author

I'll open the accompanying PR in pydantic once we merge this and do a release. It's just a 2 line diff.

Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #1424 will not alter performance

Comparing bug-fix-wednesday (0c49521) with main (cd04138)

Summary

✅ 155 untouched benchmarks

@sydney-runkle
Copy link
Member Author

Doesn't feel like a meaningful improvement, closing.

@sydney-runkle sydney-runkle deleted the bug-fix-wednesday branch October 28, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant