Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: add 'millisecond' option to ser_json_timedelta" #1503

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

sydney-runkle
Copy link
Member

We're planning on adding support for this, but with a different API as mentioned here.

@sydney-runkle sydney-runkle changed the title Revert "feat: add 'millisecond' option to ser_json_timedelta Revert "feat: add 'millisecond' option to ser_json_timedelta" Oct 25, 2024
Copy link

codspeed-hq bot commented Oct 25, 2024

CodSpeed Performance Report

Merging #1503 will not alter performance

Comparing revert-float-s-ms-stuff (c4c2ee2) with main (9b21b0f)

Summary

✅ 155 untouched benchmarks

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I think this is the right choice and look forward to the final design in 2.11 :)

@sydney-runkle sydney-runkle merged commit 8568136 into main Oct 29, 2024
28 of 29 checks passed
@sydney-runkle sydney-runkle deleted the revert-float-s-ms-stuff branch October 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants