reject is_instance inputs based on their type, not the mode #765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This changes the way the
is-instance
validator is disabled to reject inputs based on whether they originated from Python or JSON, not based on the parse mode.This allows
is_instance
validation to be possible when coming from JSON, provided you use a before or wrapping validator function (etc) which coerces the input to Python first.Related issue number
Ref pydantic/pydantic#6573
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @samuelcolvin