Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced pydantic_core deprecated method #100

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Replaced pydantic_core deprecated method #100

merged 1 commit into from
Oct 21, 2023

Conversation

camcima
Copy link

@camcima camcima commented Oct 18, 2023

Partly addresses issue #99

More specifically, solves this deprecation warning:

py3.11/lib/python3.11/site-packages/pydantic_extra_types/phone_numbers.py:33: DeprecationWarning: `general_after_validator_function` is deprecated, use `with_info_after_validator_function` instead.
    return core_schema.general_after_validator_function(

@Viicos
Copy link
Member

Viicos commented Oct 19, 2023

This might need a bump on the required pydantic version:

pydantic-extra-types/pyproject.toml

Line 42 in 0c42c50

'pydantic>=2.0.3',

@yezz123 yezz123 changed the base branch from main to Dev October 21, 2023 22:38
@yezz123 yezz123 merged commit a334070 into pydantic:Dev Oct 21, 2023
1 of 18 checks passed
@camcima camcima deleted the deprecated-after-validator branch October 31, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camcima @Viicos @yezz123