-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Refactor Documentation for ISBN and MAC address modules #124
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 665 665
Branches 166 166
=========================================
Hits 665 665 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but could you please add back the more informative docstrings?
Does this mean that you've tried serving the |
Any chance you'll be able to incorporate some changes soon? Hoping to release a new version of |
@sydney-runkle we are ready to go! |
Thanks for your work on this docs refactor. I'd like to provide some more feedback on some of the changes, and a lot of them aren't relevant to fixing the docs build issue we ran into with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this. I've left some general comments. Ping me once you'd like another review :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
I try it locally its working fine