Fix a Pendulum date time object to have correct typing #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
07pepa
commented
Jun 10, 2024
07pepa
commented
- removed handler that vas coercing it to native datetime values
- added test to verify correct typing after parsing
This was referenced Jun 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
07pepa
force-pushed
the
fix-183-issue
branch
4 times, most recently
from
9af2ea2 to
7434305
Compare
* removed handler that vas coercing it to native datetime values * added test to verify correct typing after parsing
|
@yezz123 This is ready to merge |
This was
linked to
issues
Jun 10, 2024
yezz123
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.