Add phone number types #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHutchison
commented
Apr 9, 2023
|
I'm out of time. Will look at the issues caught by the CI later |
|
Hello @JamesHutchison you can rebase this, and its will work! I will give it a review! |
yezz123
reviewed
Apr 9, 2023
yezz123
approved these changes
Apr 10, 2023
|
I add some changes! and test it locally its works fine! Thank you @JamesHutchison ⭐ |
JamesHutchison
commented
Apr 10, 2023
| @@ -2,22 +2,18 @@ | |||
|
|
|||
| from typing import Any, Callable, Generator | |||
|
|
|||
| import phonenumbers | |||
There was a problem hiding this comment.
This makes phonenumbers a requirement. This is probably fine as it isn't the biggest library, however the ImportError try block no longer makes sense below.
There was a problem hiding this comment.
Ah thanks it was an issue 👍🏻
|
Just to make sure, is the default format E.164 standard? |
|
The default format is |
|
How to set the default region code or the format type while using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a generic international phone number and a phone number type that defaults to the US. The default format includes extensions.
Feel free to comment heavily.
Addresses:
From pydantic/pydantic#5012