Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Add documentation for PhoneNumber and ABARoutingNumber #60

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Jun 7, 2023

Changes

  • Add documentation for PhoneNumber and ABARoutingNumber.
  • Add mkdocs configuration to run locally.

@Kludex
Copy link
Member Author

Kludex commented Jun 7, 2023

please review

favicon: 'favicon.png'

repo_name: pydantic/pydantic
repo_url: https://github.com/pydantic/pydantic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to mention pydantic repo here because it's under pydantic doc. right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that line is needed. The whole mkdocs configuration here is only used for local development, nothing more.

@Kludex Kludex merged commit 88677ad into main Jun 7, 2023
@Kludex Kludex deleted the docs/routing-number-and-phone-numbers branch June 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants