speedup __instancecheck__ check on BaseModel when they fail (#4081)

* speedup __instancecheck__ check on BaseModel when they fail

* add change description

* linting

changes/4081-samuelcolvin.md

@@ -0,0 +1 @@
+Speedup `__isinstancecheck__` on pydantic models when the type is not a model, may also avoid memory "leaks".

pydantic/main.py

@@ -295,6 +295,14 @@ def is_untouched(v: Any) -> bool:
 
         return cls
 
+    def __instancecheck__(self, instance: Any) -> bool:
+        """
+        Avoid calling ABC _abc_subclasscheck unless we're pretty sure.
+
+        See #3829 and python/cpython#92810
+        """
+        return hasattr(instance, '__fields__') and super().__instancecheck__(instance)
+
 
 object_setattr = object.__setattr__
 

tests/test_edge_cases.py

@@ -1932,3 +1932,17 @@ def __new__(cls, data: int):
 
     m = MyModel(my_int=IntSubclass(123))
     assert m.my_int.__class__ == IntSubclass
+
+
+def test_model_issubclass():
+    assert not issubclass(int, BaseModel)
+
+    class MyModel(BaseModel):
+        x: int
+
+    assert issubclass(MyModel, BaseModel)
+
+    class Custom:
+        __fields__ = True
+
+    assert not issubclass(Custom, BaseModel)