Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version_info to make creating issues easier #1071

Merged
merged 3 commits into from
Dec 4, 2019

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Dec 3, 2019

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable

@samuelcolvin samuelcolvin added the meta high level, conceptual label Dec 3, 2019
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #1071 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1071   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          20      20           
  Lines        3350    3365   +15     
  Branches      661     663    +2     
======================================
+ Hits         3350    3365   +15
Impacted Files Coverage Δ
pydantic/utils.py 100% <100%> (ø) ⬆️
pydantic/version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9982eb4...1be8f14. Read the comment docs.

@samuelcolvin samuelcolvin force-pushed the pydantic-version-info branch from e166d09 to 9769960 Compare December 3, 2019 15:51
@dmontagu
Copy link
Contributor

dmontagu commented Dec 4, 2019

This will help a lot!

@samuelcolvin samuelcolvin merged commit 9255012 into master Dec 4, 2019
@samuelcolvin samuelcolvin deleted the pydantic-version-info branch December 4, 2019 15:14
andreshndz pushed a commit to cuenca-mx/pydantic that referenced this pull request Jan 17, 2020
* add version_info to make creating issues easier

* improve version_info()

* improve contributing docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta high level, conceptual
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants