-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetterDict example #2463
Add GetterDict example #2463
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2463 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5099 5100 +1
Branches 1048 1048
=========================================
+ Hits 5099 5100 +1
Continue to review full report at Codecov.
|
I've also documented the Could you please confirm this assumption? |
@nuno-andre Thanks a lot for this doc, it was needed! |
Of course, just wanted to confirm that it wasn't an unintended behavior or a regression. |
@nuno-andre can you add a change file please? :) |
Done! I've just realized I'd completely ignored the PR template. Sorry for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks good.
please update, otherwise I'll accept that one tiny change some time soon and merge. |
Co-authored-by: Samuel Colvin <samcolvin@gmail.com>
I guess this CI error isn't related to the PR, right? |
no, that was just a problem with that CI script. |
Here is a very simple example of how to subclass
GetterDict
to process a class with no mapping protocol while dealing with the impedance mismatch between models (DOM's attributes and children vs OOP's properties).I have added three optional fields to show "missing attribute", "missing children", and "missing children attribute".
closes #1745