Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _field_name_for_signature docstring #9958

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

s-rigaud
Copy link
Contributor

Read the doctring after the changes made by this PR, seems to be wrong 🤔

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 24, 2024
@sydney-runkle
Copy link
Member

To clarify - the PR didn't change the behavior, but I agree, the docstring should be fixed.

@sydney-runkle sydney-runkle enabled auto-merge (squash) July 24, 2024 18:35
@sydney-runkle sydney-runkle added relnotes-ignore Omit this PR from the release notes. and removed relnotes-fix Used for bugfixes. labels Jul 24, 2024
Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #9958 will not alter performance

Comparing s-rigaud:main (d145766) with main (9de2c25)

Summary

✅ 14 untouched benchmarks

@sydney-runkle sydney-runkle merged commit 630cc56 into pydantic:main Jul 24, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-ignore Omit this PR from the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants