Fixed Unbound Variable edge access when BinGrouper is empty
#3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug surfaced when I was using a grouper on an empty array. Since the for loop ends without assign edge, it leads to the UnboundVariableError. |
|
can post an example that reproduces (or even better, add a test for this error?) |
|
Ask and you shall receive. |
|
can u setup Travis as well, see CONTRIBUTING rebase into one commit and then push to have Travis run the tests let me know if u need any help thxs |
Incorrectly accessed variable `edge` instead of pre-filled value `start`. Signed-off-by: Kevin Stone <kevinastone@gmail.com>
|
Lock and load. |
|
I can't take it with these RELEASE.rst conflicts. Merged manually via 99137af. Thanks! |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrectly accessed variable
edgeinstead of pre-filled valuestart.Signed-off-by: Kevin Stone kevinastone@gmail.com