refactor: remove custom scrollbars (#1337)

* refactor: remove scrollbar customization * remove the mixin method
pydata · May 26, 2023 · 5facdea · 5facdea
1 parent 43fbab8
commit 5facdea
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 48 deletions.
diff --git a/src/pydata_sphinx_theme/assets/styles/abstracts/_mixins.scss b/src/pydata_sphinx_theme/assets/styles/abstracts/_mixins.scss
@@ -2,42 +2,6 @@
 * SASS Mixins
 *********************************************/
 
-/**
-* Scrollbars should be thinner and slightly rounded, with a grey background
-* ref: https://www.nngroup.com/articles/scrolling-and-scrollbars/
-*/
-@mixin scrollbar-style() {
-  &::-webkit-scrollbar {
-    width: 0.5rem;
-    height: 0.5rem;
-  }
-
-  &::-webkit-scrollbar-thumb {
-    background: var(--pst-color-text-muted);
-    border-radius: 0.25rem;
-  }
-
-  &::-webkit-scrollbar-track {
-    background: transparent;
-  }
-
-  &::-webkit-scrollbar-thumb {
-    background: var(--pst-color-on-surface);
-  }
-
-  // Hovering behavior for the scrollbar
-  // Include both hovering on the parent and on the thumb in case thumb is outside parent
-  &:hover {
-    &::-webkit-scrollbar-thumb {
-      background: var(--pst-color-text-muted);
-    }
-  }
-
-  &::-webkit-scrollbar-thumb:hover {
-    background: var(--pst-color-text-muted);
-  }
-}
-
 /**
  * A consistent box shadow style we apply across elements.
  */

diff --git a/src/pydata_sphinx_theme/assets/styles/base/_base.scss b/src/pydata_sphinx_theme/assets/styles/base/_base.scss
@@ -13,8 +13,6 @@ body {
   display: flex;
   flex-direction: column;
 
-  @include scrollbar-style();
-
   // hack to avoid the black background on some browser including Safari
   &::-webkit-scrollbar-track {
     background: var(--pst-color-background);
@@ -170,8 +168,6 @@ pre {
   border: 1px solid var(--pst-color-border);
   border-radius: $admonition-border-radius;
 
-  @include scrollbar-style();
-
   .linenos {
     opacity: 0.5;
     padding-right: 10px;

diff --git a/src/pydata_sphinx_theme/assets/styles/content/_math.scss b/src/pydata_sphinx_theme/assets/styles/content/_math.scss
@@ -37,7 +37,7 @@ div.math {
     flex-grow: 1;
     padding-bottom: 0.2rem;
     overflow: auto;
-    @include scrollbar-style();
+
     // Set height to 0 so that it does not cause scrollbars to appear
     // ref: https://github.com/mathjax/MathJax/issues/2521
     mjx-assistive-mml {

diff --git a/src/pydata_sphinx_theme/assets/styles/content/_tables.scss b/src/pydata_sphinx_theme/assets/styles/content/_tables.scss
@@ -9,8 +9,6 @@ table {
   max-width: 100%;
   overflow: auto;
 
-  @include scrollbar-style();
-
   // default to table-center
   margin-left: auto;
   margin-right: auto;

diff --git a/src/pydata_sphinx_theme/assets/styles/extensions/_notebooks.scss b/src/pydata_sphinx_theme/assets/styles/extensions/_notebooks.scss
@@ -42,8 +42,6 @@ div.nblast.container {
 div.cell_output .output {
   max-width: 100%;
   overflow-x: auto;
-
-  @include scrollbar-style();
 }
 
 // Dark theme special-cases

diff --git a/src/pydata_sphinx_theme/assets/styles/sections/_sidebar-primary.scss b/src/pydata_sphinx_theme/assets/styles/sections/_sidebar-primary.scss
@@ -17,7 +17,6 @@
   border-right: 1px solid var(--pst-color-border);
   background-color: var(--pst-color-background);
   overflow-y: auto;
-  @include scrollbar-style();
 
   font-size: var(--pst-sidebar-font-size-mobile);
   @include media-breakpoint-up($breakpoint-sidebar-primary) {

diff --git a/src/pydata_sphinx_theme/assets/styles/sections/_sidebar-secondary.scss b/src/pydata_sphinx_theme/assets/styles/sections/_sidebar-secondary.scss
@@ -20,8 +20,6 @@
   // Color and border
   background-color: var(--pst-color-background);
   overflow-y: auto;
-
-  @include scrollbar-style();
 }
 
 .sidebar-secondary-item {