fix: don't display the warning bar if there is an issue (#1420)

but don't block the whole javascript page loading
pydata · Aug 23, 2023 · fd3f8c5 · fd3f8c5
1 parent 78d60a3
commit fd3f8c5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js b/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
@@ -425,9 +425,10 @@ function showVersionWarningBanner(data) {
   var preferredEntries = data.filter((entry) => entry.preferred);
   if (preferredEntries.length !== 1) {
     const howMany = preferredEntries.length == 0 ? "No" : "Multiple";
-    throw new Error(
-      `[PST] ${howMany} versions marked "preferred" found in versions JSON`
+    console.log(
+      `[PST] ${howMany} versions marked "preferred" found in versions JSON, ignoring.`
     );
+    return;
   }
   const preferredVersion = preferredEntries[0].version;
   const preferredURL = preferredEntries[0].url;