Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose article_footer in the conf.py #1244

Closed
12rambau opened this issue Mar 13, 2023 · 6 comments · Fixed by #1333
Closed

expose article_footer in the conf.py #1244

12rambau opened this issue Mar 13, 2023 · 6 comments · Fixed by #1333

Comments

@12rambau
Copy link
Collaborator

12rambau commented Mar 13, 2023

I wanted to replace the prev and next buttons by a "aske the community" and a "last uypdated at" buttons but I didn't managed as the article_footer is not exposed to the end user. What do you think if we start exposing it the same way we expose "article_header"?

@drammock
Copy link
Collaborator

I think this was addressed by #1215. @12rambau please feel free to re-open if I'm misunderstanding.

@12rambau 12rambau reopened this Mar 21, 2023
@12rambau 12rambau reopened this Mar 28, 2023
@12rambau
Copy link
Collaborator Author

It's not exactly the same, we expose the footer_content which is larger (it goes under the left-sidebar)

@drammock
Copy link
Collaborator

drammock commented Apr 4, 2023

I must be misunderstanding. If I look at the diagram here it seems to show:

  • article_footer_items (under article only)
  • content_footer_items (under article and right sidebar)
  • footer_start and footer_end (under everything)

Isn't the first one of those the thing you're asking for?

@12rambau
Copy link
Collaborator Author

12rambau commented Apr 4, 2023

when I reopened this one the stable version was still 0.13.2 where the article_footer_items was not there yet.

let me check from my side and I'll close it if manage to do what I need in my docs

@12rambau
Copy link
Collaborator Author

I knew something was off. so the article_footer space does exist but can only be filled if show_prev_next is set to True. I think this is not the intended behavior

@drammock
Copy link
Collaborator

article_footer space does exist but can only be filled if show_prev_next is set to True. I think this is not the intended behavior

Agreed, that is not how it should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants