fix: create a dedicated area for the prev-next buttons #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
reviewed
May 24, 2023
There was a problem hiding this comment.
this looks reasonable to me. Needs to update https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/layout.html#layout-article-footer though I think?
drammock
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1244
There was multipple ways of solving this one. My take is that the prev-next button is a Sphinx feature so it is expected by newcomers. Based on this idea I assumed that people may want to have an article footer AND a prev-next button.
I did created a new section in the layout only listening to the
show_prev_nextparameter and free thebd-article-footer, it is by default empty and will only be displayed if something is set inside.