Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version switcher JS does not add version spans to both menus #1304

Closed
jpfeuffer opened this issue Apr 24, 2023 · 2 comments
Closed

Version switcher JS does not add version spans to both menus #1304

jpfeuffer opened this issue Apr 24, 2023 · 2 comments
Labels
tag: javascript Pull requests that update Javascript code

Comments

@jpfeuffer
Copy link
Contributor

This means when resizing to a smaller screen, the other dropdown button/menu element in the sidebar will be used
and will be empty.

https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js#L348
@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Apr 24, 2023 •
edited
Loading

Also the following line appears not to work:
https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js#L355

Why is it a quoted string? Can JS just convert it?
Even if removing the quotes, in my version of the pydata theme, the variable is called theme_switcher_version_match not version_switcher_version_match

This is the actual cause for #1128

jpfeuffer added a commit to jpfeuffer/pydata-sphinx-theme that referenced this issue Apr 24, 2023
@jpfeuffer
fixes pydata#1304
5338637
@jpfeuffer jpfeuffer mentioned this issue Apr 24, 2023
Closed
@drammock drammock mentioned this issue May 11, 2023
Closed
drammock pushed a commit to jpfeuffer/pydata-sphinx-theme that referenced this issue May 12, 2023
@jpfeuffer @drammock
fixes pydata#1304
459ceda
@trallard trallard added the tag: javascript Pull requests that update Javascript code label May 24, 2023
@drammock drammock mentioned this issue Jun 8, 2023
Closed
@drammock
Copy link
Collaborator

this was fixed in #1344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tag: javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: version selector JS jpfeuffer/pydata-sphinx-theme
3 participants
@drammock @jpfeuffer @trallard