Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Design Update for Focus State - Links #1397

Closed
smeragoel opened this issue Aug 1, 2023 · 5 comments
Closed

Proposed Design Update for Focus State - Links #1397

smeragoel opened this issue Aug 1, 2023 · 5 comments
Labels
tag: accessibility Issues related to accessibility issues or efforts

Comments

@smeragoel
Copy link

TL;DR:

This issue proposes a new design for the focus state of links, aiming to meet WCAG 2.1 guidelines. We have three options:

Design Options

image

Feedback from the team is needed to finalize the focus state design.

Background on WCAG requirements (courtesy of @trallard)

Proposed Design Options

Design Options

image

  1. Box style with monochromatic teal color
  2. Underline style with monochromatic teal color
  3. Box style with teal + purple colors

Here is a demo of these options in light and dark mode:

Light Mode

image

Dark Mode

image

My opinion:

For style, I prefer box over underline. Because links have an underline in general, I think adding just a thicker underline in focus states could be missed, and adding a full box would be a more visible change. So (1,3) > (2)
For colours, I think that the monochromatic colour scheme is better. I see some visual vibrations with the purple in dark mode, and I added that option to show how that would look, and I feel the monochrome version is more visually stable. So (1,2) > (3)

Overall, I would rank the options like this: 1 > 2 > 3

@12rambau
Copy link
Collaborator

12rambau commented Aug 2, 2023

I don't have any specific competence in accessibility design so this is just me thinking out loud.
I fully agree that underlying is not differentiating enough wit the normal links. It's so much different that I first thought you wanted to change the hover state (yes it's 7:00 here and my coffee is still in its mug). So for me 2 is a strong no.
I agree with your color analysis, monochromatic blends better in the template. It will also be easier to maintain as it will always work in both theme.

@trallard trallard added the tag: accessibility Issues related to accessibility issues or efforts label Aug 3, 2023
@trallard
Copy link
Collaborator

trallard commented Aug 3, 2023

I am in favour of 1 too: Box style with monochromatic teal color

it is the right balance between being noticeable and not too on your face or distracting

@drammock
Copy link
Collaborator

drammock commented Aug 7, 2023

I also endorse option 1. Sounds like we're unanimous: full speed ahead!

@trallard
Copy link
Collaborator

trallard commented Aug 8, 2023

Nice one team.
@gabalafou will be taking on the implementation of this one.

@trallard
Copy link
Collaborator

trallard commented Jun 4, 2024

Completed via #1564

@trallard trallard closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: accessibility Issues related to accessibility issues or efforts
Projects
None yet
Development

No branches or pull requests

4 participants