-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize and accessibilize the focus, hover and other styles across the theme #1402
Conversation
This is a first pass so that people can take a look at the results sooner rather than later. There are a lot of rough edges that need to be cleaned up, such as:
|
Styling looks pretty consistent across browsers I tested on Mac OS: Chrome, Safari, Firefox. Exception: outline does not surround image link on Safari and Firefox. |
Thanks for tackling this @gabalafou. Link to CI build: https://pydata-sphinx-theme--1402.org.readthedocs.build/en/1402/ tabbing through the homepage (firefox on linux) I see:
Seeing the search box remindes me that it's currently the only place we use our "accent" color, and makes me realize that we didn't even consider using the accent color as focus indicator in #1397. Was that an intentional omission @smeragoel? |
That's a great suggestion about using the accent colour, I hadn't considered it before but it seems like a very viable idea. The colour clash and inconsistent styling will be addressed soon. This styling was just intended for links, and I am working on creating the focus styles for other interactive elements - buttons, cards, dropdowns etc. I'm going to consider both our primary and accent colour for focus states for now, and make a decision based on what works better for all elements. Thanks again for the suggestion @drammock! |
Great feedback yall! This is exactly what I was hoping to generate by putting up some code quickly so people could play with the results. While we re-think the design, I've put this PR in draft mode. |
9ef331a
to
e86e0ab
Compare
This PR went through a few different phases, but ultimately it is superseded by work on the feature-focus branch